today in romhacking: i have a weird bug where using a potion or a PP Up will fucking Annihilate the rom ive been working off of. like if you use a potion it makes this absolutely awful creepypasta noise and looks like this and the game is stuck forever

a PP Up "merely" resets the game back to the title screen. i can't really figure out what's doing it but it seems to be something on the end of the original rom ive been using as my work base, putting in a clean new rip makes it all okay
how this works is... i am using two codebases that work in conjunction with each other, Dynamic Pokedex Expansion and Complete FireRed Upgrade. DPE handles expanding the Pokemon, changing and adding graphics, and their movesets, as well as available TMs and Move Tutors. CFRU handles the... everything else. Bringing a Gen 3 Pokemon game's code up to par with a modern one, and all of the moves, gameplay functions, the engine stuff. These things are best applied to a rom last - so stuff like editing the overworld maps, some graphical stuff outside of the scope of these codebases (like PC box graphics, the "Welcome to the world of Pokemon" intro, menu screens) I slot into the initial, otherwise clean vanilla rom first before running it through these. I have meticulous backups of all of the graphics and changes I've made. after that, it just gets run through some python scripts and jacks in all the code I've edited from these bases.
So with that in mind... I don't really have to redo a whole lot here in order to determine the cause of this bug - or, what's more likely is that in the process of reimplementing everything, i create a rom that doesn't have this bug with healing items, and I never quite understand why it happened to begin with. it won't even really be time consuming to do. But... you know how when you get to a fog door in a Fromsoft game you kind of just wait around it because you have some level of anxiety about going in and doing the boss fight? that is kind of where i am at. i guess it's something that requires a level of focus i am not prepared to give right now.

pic unrelated i just figure i need to cap this off with something.
