progress, slowly. I need to refactor a lot of how I handle the debugging output for printing the image metadata table to avoid a lot of private accesses for things I don't wish to expose in the library as sensible things you should be able to read/write.
I also split out the command utility file into a bunch of sub-commands so it was easier to see where the lingering mess was; and surprise it's pretty much all in my "scan" command which is absolutely last on my list to fix until I fix everything else first.
I'd love to just shush pylint up here, but I know it's right about every last complaint it has here and I want to get to a smooth 0 error baseline before pushing to the public repo so it'll be easier to add individual changes/fixes/features in the future without worrying about if I've regressed something else ...
Really wish I was better at designing complex components, sheesh
but hey, mypy strict passing 100% is very satisfying ^_^
nago@fedora ~/s/cici (devel)> make check-dev
ACTIVATE .dev-venv
make[1]: Entering directory '/home/nago/src/cici'
JOB ID : 8311b44ae54247ad2291b6978a100143a6a32567
JOB LOG : /home/nago/avocado/job-results/job-2024-07-08T11.45-8311b44/job.log
(2/5) tests/flake8.sh: STARTED
(4/5) tests/mypy.sh: STARTED
(3/5) tests/isort.sh: STARTED
(1/5) tests/black.sh: STARTED
(5/5) tests/pylint.sh: STARTED
(3/5) tests/isort.sh: PASS (0.10 s)
(1/5) tests/black.sh: PASS (0.11 s)
(2/5) tests/flake8.sh: PASS (0.22 s)
(4/5) tests/mypy.sh: PASS (0.46 s)
(5/5) tests/pylint.sh: FAIL (3.05 s)
RESULTS : PASS 4 | ERROR 0 | FAIL 1 | SKIP 0 | WARN 0 | INTERRUPT 0 | CANCEL 0
JOB TIME : 3.57 s
Log file "stdout" content for test "5-tests/pylint.sh" (FAIL):
************* Module cici.tool
cici/tool.py:58:11: W0718: Catching too general exception Exception (broad-exception-caught)
************* Module cici.imgmeta
cici/imgmeta.py:103:15: W0718: Catching too general exception Exception (broad-exception-caught)
************* Module cici.binary
cici/binary.py:624:58: W0212: Access to a protected member _kind of a client class (protected-access)
cici/binary.py:636:19: W0212: Access to a protected member _imgmeta of a client class (protected-access)
cici/binary.py:637:19: W0212: Access to a protected member _imgmeta of a client class (protected-access)
cici/binary.py:638:19: W0212: Access to a protected member _imgmeta of a client class (protected-access)
cici/binary.py:641:19: W0718: Catching too general exception Exception (broad-exception-caught)
cici/binary.py:1209:19: W0718: Catching too general exception Exception (broad-exception-caught)
cici/binary.py:1333:20: W0212: Access to a protected member _imgmeta of a client class (protected-access)
************* Module cici.commands.info
cici/commands/info.py:53:17: W0511: TODO - I should present something more helpful than this. (fixme)
cici/commands/info.py:89:5: W0511: TODO: fix this to be the default, and ensure that the output (fixme)
************* Module cici.commands.repair
cici/commands/repair.py:20:13: W0511: TODO: pass repair=True to validate_images? (fixme)
************* Module cici.commands.scan
cici/commands/scan.py:41:4: C0103: Class constant name "bad_magic" doesn't conform to UPPER_CASE naming style (invalid-name)
cici/commands/scan.py:42:4: C0103: Class constant name "bad_header" doesn't conform to UPPER_CASE naming style (invalid-name)
cici/commands/scan.py:43:4: C0103: Class constant name "bad_image_table" doesn't conform to UPPER_CASE naming style (invalid-name)
cici/commands/scan.py:44:4: C0103: Class constant name "bad_image_data" doesn't conform to UPPER_CASE naming style (invalid-name)
cici/commands/scan.py:45:4: C0103: Class constant name "bad_strictness" doesn't conform to UPPER_CASE naming style (invalid-name)
cici/commands/scan.py:46:4: C0103: Class constant name "ok_warn" doesn't conform to UPPER_CASE naming style (invalid-name)
cici/commands/scan.py:47:4: C0103: Class constant name "ok_pristine" doesn't conform to UPPER_CASE naming style (invalid-name)
cici/commands/scan.py:60:15: W0718: Catching too general exception Exception (broad-exception-caught)
cici/commands/scan.py:65:15: W0718: Catching too general exception Exception (broad-exception-caught)
cici/commands/scan.py:70:15: W0718: Catching too general exception Exception (broad-exception-caught)
cici/commands/scan.py:75:15: W0718: Catching too general exception Exception (broad-exception-caught)
cici/commands/scan.py:106:4: W0613: Unused argument 'autorepair' (unused-argument)
************* Module cici.commands.extract
cici/commands/extract.py:35:5: W0511: TODO: Add output directory (fixme)
************* Module cici.commands.check
cici/commands/check.py:12:5: W0511: TODO: add fatal warnings (fixme)
------------------------------------------------------------------
Your code has been rated at 9.88/10 (previous run: 9.88/10, +0.00)