favorite: proooobably the DualShock line? i really like the shape, button/stick layout, and build quality (excluding the PS3 version), and the DS4 i use with my MiSTer has a real nice heft to it. it feels good in the hands. not a big fan of the split d-pad design, though, it's kinda hell on the thumb after a while. the SNES controller is probably a close second
least favorite: ughhh, there are a FEW and it's hard to pick one. the Atari 7800 two-button stick, the original NA Saturn pad, and the N64 controller are some of the worst ones i've actually used, though if i ever get my hands on like a Fairchild Channel F or Bally Astrocade controller we might have a clear #1